Conversation
mattwd7
reviewed
Sep 19, 2025
Comment on lines
234
to
240
| def self.parse(xml) | ||
| parser.parse(xml) | ||
| rescue REXML::ParseException => e | ||
| return {} if e.message.match?(/^Malformed XML: No root element/) | ||
|
|
||
| raise e | ||
| end |
There was a problem hiding this comment.
this seems kinda brittle – if the error message changes, this will require update again. I think instead we want to get ahead of this error if the error-provoking conditions are met, e.g.
Suggested change
| def self.parse(xml) | |
| parser.parse(xml) | |
| rescue REXML::ParseException => e | |
| return {} if e.message.match?(/^Malformed XML: No root element/) | |
| raise e | |
| end | |
| def self.parse(xml) | |
| return {} if xml.blank? | |
| parser.parse(xml) | |
| end |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately blank? is not pure Ruby, it's coming from ActiveSupport. xml.strip == '' should do fine, wdyt?
kiskoza
force-pushed
the
rexml-3-4-3
branch
from
59d6bdc to
da92ada
Compare
mattwd7
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84